Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French translation #158

Closed
wants to merge 1 commit into from
Closed

Update French translation #158

wants to merge 1 commit into from

Conversation

orditeck
Copy link

No description provided.

@inxomnyaa
Copy link
Owner

I think this is irrelevant

I can find translations for conserve, preserve, etc, all with the same meaning.

"Keep air" is meant to be "Preserve blocks with type air"

@orditeck
Copy link
Author

orditeck commented Oct 18, 2019

As a native French speaker from Québec, I can assure you that this is relevant.

"Garder" and "Conserver" have two different meanings.

When you say that you can find translations with the same meanings, may I ask based on what you're arriving to the conclusion that they have the same meaning?

"Garder" can mean "Conserver", but it can also mean "Surveiller" (watch).
And in such a small sentence, right choice of word matters.

"Conserver" is clear, is not to be interpreted based on context and is the right choice to make it obvious for French-speaking people.

That was a rude way to close a PR, asking the question of why I'm suggesting this would have been better IMO. I, however, should have added what I just explained in my original PR, so sorry about that.

@orditeck orditeck deleted the patch-1 branch October 18, 2019 16:52
@orditeck
Copy link
Author

orditeck commented Oct 18, 2019

"Keep air" is meant to be "Preserve blocks with type air"

Suggestion: remplace "Keep air" with "Preserve blocks with type air".

"Preserve" is very eloquent: to cause (an object) to remain in its initial condition.

And in French, you could go with Maintenir, Garder, Conserver.
"Conserver" is definitely the right choice though.

@orditeck
Copy link
Author

And it shouldn't be "Conserver l'air" or "Garder l'air" in French.

It translates to "Keep the air" 🙈

So my PR should be "Conserver le type air [pour les blocs]". The [pour les blocs] could be removed but add rock-solid precision.

@inxomnyaa
Copy link
Owner

That was a rude way to close a PR

Shit, i am arguing with a france.

Repository owner locked as spam and limited conversation to collaborators Oct 18, 2019
@inxomnyaa
Copy link
Owner

Just asking: Are you that bored to write 3 messages for a 1 word commit? You could've fixed or commented on the french language PR instead (#78 #98 #12 #154 #158 #144 ), like literally, there are already enough PR's for that

@inxomnyaa inxomnyaa added the Spam Spamming or going off toppic, or just being annoying label Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Invalid Spam Spamming or going off toppic, or just being annoying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants