Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix]: Inform about different version #2897

Closed
wants to merge 4 commits into from

Conversation

GermanBluefox
Copy link
Contributor

@GermanBluefox GermanBluefox commented Sep 6, 2024

For Bugfixes:

Sometimes the update of adapter happens without "upload" command. To detect that versions in DB and on disk differs, this bugfix writes a warning int log in this case.

Additionally it helps split this PR #2875 into really essential changes

Copy link
Collaborator

@Apollon77 Apollon77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just adjust the wording a bit

packages/adapter/src/lib/adapter/adapter.ts Outdated Show resolved Hide resolved
@foxriver76
Copy link
Collaborator

foxriver76 commented Sep 6, 2024

As far as I know the case where this happens is GitHub installs where we currently are aware of and did this on purpose until now. So this will always lead to this scenario if we don’t want this anymore it would be more like should we also do the upload on GH installs? (URL command)

Or is there are valid reason why we prevent the upload there?

@Apollon77
Copy link
Collaborator

Also github installs shoukld have an auto upload ...in my eyes there should be no case anymore where it is not executed

@foxriver76
Copy link
Collaborator

foxriver76 commented Sep 6, 2024

Also github installs shoukld have an auto upload ...in my eyes there should be no case anymore where it is not executed

Then I would tend to say let’s fix this instead of adding a log warning where we know why it happens. Or are there other cases where we are sure that it was no url install (Admin npm or GitHub dialog)

I could look into this

@Apollon77
Copy link
Collaborator

Apollon77 commented Sep 6, 2024

I agree!. But not sure what to fix because code should do that already. maybe the log helps to see if there are cases any ore :-) as said ... should not

@GermanBluefox
Copy link
Contributor Author

This is targeting to help to find the error with installations from git/npm so the upload is not executed automatically after installation

@foxriver76
Copy link
Collaborator

is already integrated with the auto upload + log

@foxriver76 foxriver76 closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants