[typing] Added types to adapter.ts #2922
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is really easy to merge and it is manageable |
foxriver76
requested changes
Nov 13, 2024
| @@ -1437,8 +1454,7 @@ export class AdapterClass extends EventEmitter { | |||
| options?: Record<string, any> | null, | |||
| ): Promise<(ioBroker.AnyObject | null)[]> { | |||
| try { | |||
| const res = await this.#objects!.getObjects(keys, options); | |||
| return res; | |||
| return this.#objects!.getObjects(keys, options); | |||
There was a problem hiding this comment.
This will lead the catch not being functional anymore, can we please minimize PRs to the things we actually want to achieve with them. Personally I don't know what the goal of the adapter.ts changes is as none really rely on the added types.
| @@ -272,11 +279,12 @@ | |||
| "jsonlOptions": { | |||
| "$ref": "#/definitions/JsonlOptions" | |||
| }, | |||
| "maxQueue": { | |||
| "type": "number", | |||
| "description": "do not let messages grow without a limit" | |||
There was a problem hiding this comment.
descriptions seem to start with an uppercase letter in general.
| @@ -513,6 +521,10 @@ | |||
| }, | |||
| "jsonlOptions": { | |||
| "$ref": "#/definitions/JsonlOptions" | |||
| }, | |||
| "maxQueue": { | |||
There was a problem hiding this comment.
as used multiple times could be put into a definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some typing to adapter.ts
mostly for 'adapter.systemConfig' (I thought that it is content of 'systetm.config' object)
Tests