Makes sure to return promise from setObject logic. … #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+2779
to
+2783
| setObject( | ||
| id: string, | ||
| obj: ioBroker.SettableObject, | ||
| callback?: ioBroker.SetObjectCallback, | ||
| ): Promise<ioBroker.NonNullCallbackReturnTypeOf<ioBroker.SetObjectCallback> | void>; |
Check warning
Code scanning / CodeQL
Unreachable method overloads Warning
|
After merging we should depreacte |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects setObject and extendObject at least
Implementation details
Return the promise from _setObjectWithDefaultValue to the calling method else this gets lost when no callback was provided
Tests
If no tests added, please specify why it was not possible
change is too obbvious :-)