Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): Apply overrideUserAgent to requests #7906

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(http): Apply overrideUserAgent to requests #7906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76feabf
adding overridden userAgentString to native requests
theproducer Mar 3, 2025
98fc201
Merge branch 'main' into RDMR-554
theproducer Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions android/capacitor/src/main/java/com/getcapacitor/plugin/util/HttpRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,11 @@ public static JSObject request(PluginCall call, String httpMethod, Bridge bridge

boolean isHttpMutate = method.equals("DELETE") || method.equals("PATCH") || method.equals("POST") || method.equals("PUT");

String overriddenUserAgent = bridge.getConfig().getOverriddenUserAgentString();
if (overriddenUserAgent != null) {
headers.put("User-Agent", overriddenUserAgent);
}

URL url = new URL(urlString);
HttpURLConnectionBuilder connectionBuilder = new HttpURLConnectionBuilder()
.setUrl(url)
Expand Down
6 changes: 5 additions & 1 deletion ios/Capacitor/Capacitor/Plugins/HttpRequestHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ open class HttpRequestHandler {
guard var urlString = call.getString("url") else { throw URLError(.badURL) }
let method = httpMethod ?? call.getString("method", "GET")

let headers = (call.getObject("headers") ?? [:]) as [String: Any]
var headers = (call.getObject("headers") ?? [:]) as [String: Any]
let params = (call.getObject("params") ?? [:]) as [String: Any]
let responseType = call.getString("responseType") ?? "text"
let connectTimeout = call.getDouble("connectTimeout")
Expand All @@ -183,6 +183,10 @@ open class HttpRequestHandler {
.setUrlParams(params)
.openConnection()
.build()

if let userAgentString = config?.overridenUserAgentString {
headers["User-Agent"] = userAgentString
}

request.setRequestHeaders(headers)

Expand Down
Loading