chore: enable dynamic font scaling #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapsandapps
commented
Sep 29, 2023
src/app/app.component.scss
Outdated
| @@ -24,6 +24,8 @@ ion-menu.md ion-list-header { | |||
| padding-right: 18px; | |||
| padding-left: 18px; | |||
|
|
|||
| font-size: min(1.375rem, 36px); | |||
There was a problem hiding this comment.
I would have preferred to truncate instead of adjusting the font size, but there's no shadow part for the element I would need to target to truncate.
mapsandapps
requested review from
a team and
liamdebeasi
and removed request for
a team
liamdebeasi
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable dynamic font scaling & adjust a few things to look better at large font sizes.
See ionic-team/ionic-react-conference-app#122 for the React version.
You can test it out with:
Perhaps we don't want to merge this until the relevant link in the docs is in prod.