Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): added snapBreakpoints to sheet modals #30097

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kumibrr
Copy link

@kumibrr kumibrr commented Dec 22, 2024

Issue number: resolves #24631


What is the current behavior?

Sheet modals do not allow content scroll unless it's breakpoint is 1.

What is the new behavior?

Sheet modals now have an additional property snapBreakpoints similar to breakpoints which allows the developer to specify at which breakpoint the content of the modal should be scrollable.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Screen.Recording.2024-12-23.at.00.41.19.mov

@kumibrr kumibrr requested a review from a team as a code owner December 22, 2024 23:37
Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 11:42pm

@github-actions github-actions bot added the package: core @ionic/core package label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: sheet modal, add option to prefer scrolling when not fully expanded
1 participant