Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook examples #55

Merged
merged 2 commits into from
Jan 4, 2016
Merged

Notebook examples #55

merged 2 commits into from
Jan 4, 2016

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jan 4, 2016

Work in progress. See #54

lukecampbell added a commit that referenced this pull request Jan 4, 2016
@lukecampbell lukecampbell merged commit 3d46fa5 into ioos:master Jan 4, 2016
@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 4, 2016

Work in progress. See #54

@lukecampbell this was a "work in progress" PR to get review/input from the devs 😜

Merging is not a problem though as this PR does not change pyoos' code base.

I will keep working on another branch. And I will ping @emiliom too review https://github.com/ocefpaf/pyoos/blob/be54aee0583ae220292486295f47dcacf6208d87/notebooks/COOPS.ipynb from there.

Thanks!

@ocefpaf ocefpaf deleted the notebooks branch January 4, 2016 22:16
@lukecampbell
Copy link
Member

You can continue on this branch if you want, it won't change the PR. Any additional changes can have a new PR.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 4, 2016

Thanks. But I think I should organize the next changes a little bit better. A new branch (and PR) for each notebook/collector to make it easy for the reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants