SD-JWT VC implementation #1413

UMR1352 · 2024-09-20T12:09:52Z

Implementation of SD-JWT VC draft 5.
3 more versions of the draft have been published since we started working on this but let's ignore them for now

…solvers with the same signature

identity_credential/Cargo.toml

identity_credential/src/sd_jwt_vc/token.rs

nanderstabel · 2024-11-19T15:48:15Z

Hi I was just wondering what is the current status of this work :)

Currently when using this branch like this:

[dependencies]
identity_credential = { git = "https://github.com/iotaledger/identity.rs", branch = "feat/sd-jwt-vc", default-features = false, features = [
    "validator",
    "credential",
    "presentation",
    "domain-linkage",
    "sd-jwt-vc"
] }

which results in a couple of compilation errors:

$ cargo check 
    Checking identity_credential v1.3.1 (https://github.com/iotaledger/identity.rs?branch=feat/sd-jwt-vc#654b188e)
error[E0433]: failed to resolve: use of undeclared crate or module `futures`
 --> /home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:1:5
  |
1 | use futures::future::BoxFuture;
  |     ^^^^^^^ use of undeclared crate or module `futures`

error[E0433]: failed to resolve: use of undeclared crate or module `futures`
 --> /home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:2:5
  |
2 | use futures::future::FutureExt;
  |     ^^^^^^^ use of undeclared crate or module `futures`

error[E0308]: mismatched types
   --> /home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/builder.rs:233:46
    |
233 |       .fold(builder, |builder, (key, value)| builder.insert_claim(key, value));
    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `SdJwtBuilder<H>`, found `Result<SdJwtBuilder<H>, Error>`
    |
    = note: expected struct `SdJwtBuilder<_>`
                 found enum `std::result::Result<SdJwtBuilder<_>, sd_jwt_payload::Error>`
help: consider using `Result::expect` to unwrap the `std::result::Result<SdJwtBuilder<H>, sd_jwt_payload::Error>` value, panicking if the value is a `Result::Err`
    |
233 |       .fold(builder, |builder, (key, value)| builder.insert_claim(key, value).expect("REASON"));
    |                                                                              +++++++++++++++++

error[E0599]: no method named `boxed` found for `async` block `{async block@/home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:105:3: 105:13}` in the current scope
   --> /home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:153:4
    |
105 | /   async move {
106 | |     // Check if current type has already been checked.
107 | |     let is_type_already_checked = passed_types.contains(&current_type);
108 | |     if is_type_already_checked {
...   |
152 | |   }
153 | |   .boxed()
    | |   -^^^^^ method not found in `{async block@/home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:105:3: 105:13}`
    | |___|
    |

Some errors have detailed explanations: E0308, E0433, E0599.
For more information about an error, try `rustc --explain E0308`.
error: could not compile `identity_credential` (lib) due to 4 previous errors

I have quickly resolved them a couple of weeks ago myself just to make it work (see this).

eike-hass · 2024-11-21T08:40:56Z

Hi I was just wondering what is the current status of this work :)

Currently when using this branch like this:

[dependencies]
identity_credential = { git = "https://github.com/iotaledger/identity.rs", branch = "feat/sd-jwt-vc", default-features = false, features = [
    "validator",
    "credential",
    "presentation",
    "domain-linkage",
    "sd-jwt-vc"
] }

which results in a couple of compilation errors:

$ cargo check 
    Checking identity_credential v1.3.1 (https://github.com/iotaledger/identity.rs?branch=feat/sd-jwt-vc#654b188e)
error[E0433]: failed to resolve: use of undeclared crate or module `futures`
 --> /home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:1:5
  |
1 | use futures::future::BoxFuture;
  |     ^^^^^^^ use of undeclared crate or module `futures`

error[E0433]: failed to resolve: use of undeclared crate or module `futures`
 --> /home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:2:5
  |
2 | use futures::future::FutureExt;
  |     ^^^^^^^ use of undeclared crate or module `futures`

error[E0308]: mismatched types
   --> /home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/builder.rs:233:46
    |
233 |       .fold(builder, |builder, (key, value)| builder.insert_claim(key, value));
    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `SdJwtBuilder<H>`, found `Result<SdJwtBuilder<H>, Error>`
    |
    = note: expected struct `SdJwtBuilder<_>`
                 found enum `std::result::Result<SdJwtBuilder<_>, sd_jwt_payload::Error>`
help: consider using `Result::expect` to unwrap the `std::result::Result<SdJwtBuilder<H>, sd_jwt_payload::Error>` value, panicking if the value is a `Result::Err`
    |
233 |       .fold(builder, |builder, (key, value)| builder.insert_claim(key, value).expect("REASON"));
    |                                                                              +++++++++++++++++

error[E0599]: no method named `boxed` found for `async` block `{async block@/home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:105:3: 105:13}` in the current scope
   --> /home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:153:4
    |
105 | /   async move {
106 | |     // Check if current type has already been checked.
107 | |     let is_type_already_checked = passed_types.contains(&current_type);
108 | |     if is_type_already_checked {
...   |
152 | |   }
153 | |   .boxed()
    | |   -^^^^^ method not found in `{async block@/home/nander/.cargo/git/checkouts/identity.rs-3c836f09661bc7fb/654b188/identity_credential/src/sd_jwt_vc/metadata/vc_type.rs:105:3: 105:13}`
    | |___|
    |

Some errors have detailed explanations: E0308, E0433, E0599.
For more information about an error, try `rustc --explain E0308`.
error: could not compile `identity_credential` (lib) due to 4 previous errors

I have quickly resolved them a couple of weeks ago myself just to make it work (see this).

After solving the mentioned issues and no further comments or reviews from your side we would be ready to release.

wulfraem

Great work, very hard to find anything to even nitpick about. :D

identity_credential/src/sd_jwt_vc/metadata/display.rs

identity_credential/src/sd_jwt_vc/metadata/vc_type.rs

identity_credential/src/sd_jwt_vc/token.rs

wulfraem · 2025-01-09T10:35:10Z

identity_credential/Cargo.toml

 once_cell = { version = "1.18", default-features = false, features = ["std"] }
 reqwest = { version = "0.11", default-features = false, features = ["default-tls", "json", "stream"], optional = true }
 roaring = { version = "0.10.2", default-features = false, features = ["serde"], optional = true }
 sd-jwt-payload = { version = "0.2.1", default-features = false, features = ["sha"], optional = true }
+sd-jwt-payload-rework = { package = "sd-jwt-payload", git = "https://github.com/iotaledger/sd-jwt-payload.git", branch = "feat/sd-jwt-v11", default-features = false, features = ["sha"], optional = true }


This dependency split can be removed after iotaledger/sd-jwt-payload#14 has been merged, right? ^^

Not really, this can only be removed after we release identity 2.0. Before that we cannot refactor the code for our sd-jwt feature.

identity_credential/src/sd_jwt_vc/metadata/issuer.rs

identity_credential/src/sd_jwt_vc/metadata/display.rs

identity_credential/src/sd_jwt_vc/metadata/claim.rs

* reworked sd-jwt bindings * SdJwtVc WASM bindings * small example, many small fixes * example & small fixes * restore package.json * Update bindings/wasm/src/sd_jwt_vc/builder.rs Co-authored-by: wulfraem <[email protected]> * Update bindings/wasm/src/sd_jwt_vc/claims.rs Co-authored-by: wulfraem <[email protected]> * Update bindings/wasm/src/sd_jwt_vc/metadata/vc_type.rs Co-authored-by: wulfraem <[email protected]> * Update bindings/wasm/src/sd_jwt_vc/sd_jwt_v2/builder.rs Co-authored-by: wulfraem <[email protected]> * Update bindings/wasm/src/sd_jwt_vc/sd_jwt_v2/sd_jwt.rs Co-authored-by: wulfraem <[email protected]> * review comments --------- Co-authored-by: wulfraem <[email protected]>

Co-authored-by: wulfraem <[email protected]>

nanderstabel

Without having (had the time to) fully review everything this looks good to me now. I'm not super into the SD-JWT specifications but for our current use case everything works as expected.

Thanks for working on this feature!

UMR1352 added 15 commits June 11, 2024 14:30

Resolver trait and CompoundResolver macro

b7853fb

invert Resolver type parameters

0114b35

associated type Target instead of type parameter T

88a538e

fix type issue in #[resolver(..)] annotation, support for multiple re…

bfd5d59

…solvers with the same signature

resolver integration

5671118

Merge branch 'main' into identity2/resolver

d7c2cd9

feature gate resolver-v2

7c815c5

structures & basic operations

b28fa9a

SdJwtVc behaves as a superset of SdJwt

2f7fadf

issuer's metadata fetching & validation

0d3127f

type metadata & credential verification

55319c5

change resolver's constraints

704b395

integrity metadata

130af00

display metadata

d278060

claim metadata

0a1ed27

UMR1352 added Enhancement New feature or improvement to an existing feature Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Sep 20, 2024

UMR1352 self-assigned this Sep 20, 2024

UMR1352 added 7 commits September 20, 2024 18:06

fetch issuer's JWK (to ease verification)

8d00263

validate claim disclosability

2111e3b

add missing license header

06e31f2

resolver change, validation

e5e8537

SdJwtVcBuilder & tests

9bf907f

validation test

67a0abc

KB-JWT validation

a510185

nanderstabel reviewed Oct 7, 2024

View reviewed changes

identity_credential/Cargo.toml Outdated Show resolved Hide resolved

nanderstabel reviewed Oct 11, 2024

View reviewed changes

identity_credential/src/sd_jwt_vc/token.rs Outdated Show resolved Hide resolved

nanderstabel mentioned this pull request Oct 11, 2024

Upgrade to SD-JWT v12 & API rework iotaledger/sd-jwt-payload#14

Merged

review comment

654b188

UMR1352 added 4 commits December 11, 2024 14:19

undo resolver-v2

72333bb

Merge branch 'main' into feat/sd-jwt-vc

468809e

fix CI errors

3f992c4

make clippy happy

66f7b79

UMR1352 marked this pull request as ready for review December 11, 2024 17:31

UMR1352 requested a review from a team as a code owner December 11, 2024 17:31

UMR1352 marked this pull request as draft December 11, 2024 17:32

UMR1352 added 3 commits December 11, 2024 19:37

add missing license headers

03f1483

add 'SdJwtVcBuilder::from_credential' to easily convert into a SD-JWT VC

51e1b28

cargo clippy

035b50f

UMR1352 marked this pull request as ready for review December 12, 2024 09:58

fix wasm compilation errors, clippy

f2c0704

UMR1352 requested a review from nanderstabel December 12, 2024 12:47

wulfraem requested changes Jan 9, 2025

View reviewed changes

UMR1352 and others added 3 commits January 10, 2025 11:56

Apply suggestions from code review

00fae28

Co-authored-by: wulfraem <[email protected]>

review comments

6efd431

UMR1352 requested a review from wulfraem January 13, 2025 16:34

wulfraem approved these changes Jan 14, 2025

View reviewed changes

clippy & fmt

0a3131f

eike-hass self-requested a review January 17, 2025 15:36

nanderstabel approved these changes Jan 17, 2025

View reviewed changes

eike-hass approved these changes Jan 17, 2025

View reviewed changes

eike-hass added the Wasm Related to Wasm bindings. Becomes part of the Wasm changelog label Jan 17, 2025

UMR1352 added 2 commits January 17, 2025 17:15

clippy & fmt

2703d06

dprint fmt

6ee84b2

UMR1352 merged commit 8b6d7b8 into main Jan 20, 2025
15 checks passed

UMR1352 deleted the feat/sd-jwt-vc branch January 20, 2025 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SD-JWT VC implementation #1413

SD-JWT VC implementation #1413

UMR1352 commented Sep 20, 2024 •

edited

Loading

nanderstabel commented Nov 19, 2024

eike-hass commented Nov 21, 2024

wulfraem left a comment

wulfraem Jan 9, 2025

UMR1352 Jan 13, 2025

nanderstabel left a comment

SD-JWT VC implementation #1413

SD-JWT VC implementation #1413

Conversation

UMR1352 commented Sep 20, 2024 • edited Loading

nanderstabel commented Nov 19, 2024

eike-hass commented Nov 21, 2024

wulfraem left a comment

Choose a reason for hiding this comment

wulfraem Jan 9, 2025

Choose a reason for hiding this comment

UMR1352 Jan 13, 2025

Choose a reason for hiding this comment

nanderstabel left a comment

Choose a reason for hiding this comment

UMR1352 commented Sep 20, 2024 •

edited

Loading