Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change HexPublicKeyToBech32Address to PublicKeyHash? #2080

Closed
Thoralf-M opened this issue Feb 27, 2024 · 1 comment · Fixed by #2135
Closed

Change HexPublicKeyToBech32Address to PublicKeyHash? #2080

Thoralf-M opened this issue Feb 27, 2024 · 1 comment · Fixed by #2135
Assignees
@Thoralf-M
Labels
b-all Bindings - All
Milestone
v2.0.0 (Q1 2024)

Comments

@Thoralf-M
Copy link
Member

Conversion to bech32 address can be done with AddressToBech32 and to get the public key hash one would need to convert it from bech32 back which is more annoying I think

In the bindings core we could replace it with Blake2b256Hash which could also be called in ComputeAccountId, ComputeNftId so we have less code there
@Thoralf-M Thoralf-M added the b-all Bindings - All label Feb 27, 2024
@Thoralf-M Thoralf-M added this to the v2.0.0 (Q1 2024) milestone Feb 27, 2024
@Thoralf-M Thoralf-M mentioned this issue Mar 5, 2024
Merged
@Thoralf-M Thoralf-M linked a pull request Mar 6, 2024 that will close this issue
Replace hexPublicKeyToBech32Address by publicKeyHash #2135
Merged
@thibault-martinez
Copy link
Member

Closed by #2135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thoralf-M Thoralf-M

Labels
b-all Bindings - All
Projects
iota-sdk
Status: Done
Milestone
v2.0.0 (Q1 2024)
Development

Successfully merging a pull request may close this issue.

Replace hexPublicKeyToBech32Address by publicKeyHash Thoralf-M/iota-sdk
2 participants
@thibault-martinez @Thoralf-M