Replace hexPublicKeyToBech32Address by publicKeyHash #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Blake2b256Hash instead of ComputeAccountId/ComputeNftId/PublicKeyHash in bindings core
Thoralf-M
commented
Mar 5, 2024
bindings/nodejs/examples/how_tos/sign_and_verify_ed25519/sign-ed25519.ts
Outdated
Show resolved
Hide resolved
Thoralf-M
changed the title
thibault-martinez
approved these changes
Mar 6, 2024
DaughterOfMars
approved these changes
Mar 6, 2024
Thoralf-M
deleted the
Replacey-hexPublicKeyToBech32Address-by-publicKeyHash
branch
Thoralf-M
added a commit
to Thoralf-M/iota-sdk
that referenced
this pull request
Mar 6, 2024
* Replacey hexPublicKeyToBech32Address by publicKeyHash; Use Blake2b256Hash instead of ComputeAccountId/ComputeNftId/PublicKeyHash in bindings core * Fix typo, static instead of async * Lower case * Remove __PublicKeyHashMethod__ --------- Co-authored-by: Thibault Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Replacey hexPublicKeyToBech32Address by publicKeyHash
Use Blake2b256Hash instead of ComputeAccountId/ComputeNftId/PublicKeyHash in bindings core so we have less to maintain there
Links to any relevant issues
Closes #2080
Type of change
How the change has been tested
Tests