Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIP BlockId tests #1607

Merged
merged 78 commits into from
Jan 30, 2024
Merged

TIP BlockId tests #1607

merged 78 commits into from
Jan 30, 2024

Conversation

Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Nov 10, 2023 •
edited
Loading

Description of change

  • Uncomments the Block ID tests in Rust (2 of the 3 tests are ignored though until the TIP is updated with valid public keys)
  • Adds the same tests to the bindings

Links to any relevant issues

Closes #1391
Partially addresses #1387

@Alex6323 Alex6323 changed the title uncomment block id tests Block Id tests Nov 10, 2023
This was linked to issues Nov 10, 2023
Add TIP Block ID tests to bindings #1391
Closed
Python: fix some tests (and remove corresponding pytest ignore) #1387
Closed
@thibault-martinez thibault-martinez changed the title Block Id tests TIP BlockId tests Nov 26, 2023
@Alex6323 Alex6323 marked this pull request as ready for review December 6, 2023 15:00
thibault-martinez
thibault-martinez requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

Thoralf-M
Thoralf-M previously approved these changes Jan 30, 2024
View reviewed changes
@thibault-martinez thibault-martinez merged commit eb737eb into iotaledger:2.0 Jan 30, 2024
36 checks passed
@thibault-martinez thibault-martinez mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaughterOfMars DaughterOfMars DaughterOfMars left review comments

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TIP Block ID tests to bindings Python: fix some tests (and remove corresponding pytest ignore)
4 participants
@Alex6323 @thibault-martinez @DaughterOfMars @Thoralf-M