Use bytes for Ed25519Signature public key #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
requested changes
Jan 9, 2024
|
Yeah, I figured I'd wait until we decide whether this is even happening 😆 |
added 3 commits
January 18, 2024 09:55
Alex6323
reviewed
Jan 19, 2024
Thoralf-M
approved these changes
Jan 19, 2024
Alex6323
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Looks like using the
PublicKeytype here was a mistake, as the validation is not intended to be at the syntactic level. Unfortunately this is a breaking change, and there's no way to avoid that.Links to any relevant issues
iotaledger/inx-chronicle#1308
Type of change
Choose a type of change, and delete any options that are not relevant.