-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/node: Typed errors #1858
Merged
Merged
Feat/node: Typed errors #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@marc2332 |
Looks very promising, I'll give it a try asap! |
DaughterOfMars
previously approved these changes
Jan 22, 2024
Thoralf-M
reviewed
Jan 22, 2024
Thoralf-M
reviewed
Jan 23, 2024
Thoralf-M
approved these changes
Jan 23, 2024
DaughterOfMars
approved these changes
Jan 23, 2024
Alex6323
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds error types which match the rust errors to nodejs
OPEN QUESTIONS:
serialize_entry
call. (otherwise all fields are double string escaped and dont parse properly on js side) ->bindings/core/src/error.rsLinks to any relevant issues
Fixes #1417
Type of change
How the change has been tested
caught the new errors by their instance
Change checklist