Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ChangeAddress RemainderValueStrategy from bindings #1899

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Remove ChangeAddress RemainderValueStrategy from bindings #1899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1b1d95
Remove ChangeAddress RemainderValueStrategy from bindings
Thoralf-M Jan 29, 2024
7b05291
Merge branch '2.0' into remove-ChangeAddress-RemainderValueStrategy
thibault-martinez Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions bindings/nodejs/lib/types/wallet/transaction-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,7 @@ export interface TransactionOptions {
}

/** The possible remainder value strategies. */
export type RemainderValueStrategy =
| ChangeAddress
| ReuseAddress
| CustomAddress;

/**
* Allows to move the remainder value to a change address.
*/
export type ChangeAddress = {
/** The name of the strategy. */
strategy: 'ChangeAddress';
/** Only required for `CustomAddress`. */
value: null;
};
export type RemainderValueStrategy = ReuseAddress | CustomAddress;

/**
* Allows to keep the remainder value on the source address.
Expand Down
2 changes: 0 additions & 2 deletions bindings/python/iota_sdk/types/transaction_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,8 @@ class RemainderValueStrategy(Enum):
"""Remainder value strategy variants.

Attributes:
ChangeAddress: Allows to move the remainder value to a change address.
ReuseAddress: Allows to keep the remainder value on the source address.
"""
ChangeAddress = None
ReuseAddress = None

def to_dict(self) -> dict:
Expand Down
Loading