-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: make TaggedData data field optional #1983
Merged
Thoralf-M
merged 9 commits into
iotaledger:develop
from
Thoralf-M:python-block-from-dict
May 3, 2024
Merged
Fix: make TaggedData data field optional #1983
Thoralf-M
merged 9 commits into
iotaledger:develop
from
Thoralf-M:python-block-from-dict
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
previously approved these changes
Feb 12, 2024
Thoralf-M
force-pushed
the
python-block-from-dict
branch
from
February 12, 2024 14:53
802ec74
to
64844e1
Compare
Thoralf-M
changed the title
Fix Block::from_dict()
Fix: make TaggedData data field optional
Feb 12, 2024
thibault-martinez
previously approved these changes
Feb 12, 2024
Thoralf-M
force-pushed
the
python-block-from-dict
branch
from
February 14, 2024 10:45
d9601ab
to
89da3d2
Compare
thibault-martinez
previously requested changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conflicts
Draft for now, maybe we can find a better way (without requiring the type in the TaggedDataPayload init) |
Thoralf-M
force-pushed
the
python-block-from-dict
branch
from
May 2, 2024 07:22
a6ccbdb
to
880f2c0
Compare
1 task
DaughterOfMars
approved these changes
May 3, 2024
Thoralf-M
added a commit
that referenced
this pull request
May 7, 2024
* Fix nightly build (#1981) * Fix TransactionOptions::as_dict() for remainder_value_strategy (#1993) * Fix ClientOptions typing in wallet options (#1994) * Bump version and set release date (#1996) * Fix node.js readme example (#2220) * Fix wasm compilation, bump wasm-bindgen (#2221) * Fix wasm compilation, bump wasm-bindgen * Update dependencies * Fix: make TaggedData data field optional (#1983) * Make TaggedDataPayload::data field optional * Tag also optional, still failing * Make TaggedDataPayload work * Uncomment, fix imports and lint * Raise error * Update date * reorder union * Remove unused import, update changelog, bump version * Update rustls --------- Co-authored-by: Alex Coats <[email protected]> * Update private tangle action --------- Co-authored-by: Thibault Martinez <[email protected]> Co-authored-by: Dr-Electron <[email protected]> Co-authored-by: Alex Coats <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Without this change it fails to parse payloads where the data field is optional
Type of change
How the change has been tested