Allow using account mana for allotments, fix semantic validation #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| *output = match output { | ||
| Output::Account(a) => AccountOutputBuilder::from(&*a).with_mana(new_mana).finish_output()?, | ||
| if self.mana_allotments[&issuer_id].0 < required_allotment_mana { | ||
| let (selected_mana, required_mana) = self.mana_sums_without_allotments()?; |
There was a problem hiding this comment.
I think you'd be better off using the regular method and subtracting the specific allotment for this issuer
There was a problem hiding this comment.
Yes, that's one reason why I wrote still needs cleanup
|
Commits were partially picked for #1961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Allow using account Mana for allotments, fix semantic validation (only add allotments Mana to output Mana once)
Links to any relevant issues
#1918
Type of change
How the change has been tested
Sending a transaction with only accounts as inputs