Fix implicit account creation address syncing #2130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adding this for completeness and to be more future proof if we do changes, but currently it's actually never called since we return earlier here
Links to any relevant issues
Fixes #2103
How the change has been tested
Syncing a wallet with
and
|| (address.is_implicit_account_creation() && sync_options.sync_implicit_accounts)
above commentedstill gets basic outputs with the implicit account creation address
DEBUG sdk/src/client/node_manager/http_client.rs:87 GET: 6 ms for 200 OK http://localhost:8050/api/indexer/v2/outputs/basic?unlockableByAddress=rms1yqfz7u5aau3gkhx62kp4a2fct3wt5tmw52pz6qyy4vatm7yl3k52c94v4ts