Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit account creation address syncing #2130

Conversation

Thoralf-M
Copy link
Member

@Thoralf-M Thoralf-M commented Mar 5, 2024

Description of change

Adding this for completeness and to be more future proof if we do changes, but currently it's actually never called since we return earlier here

            || (address.is_implicit_account_creation() && sync_options.sync_implicit_accounts)
        {
            return Ok(self
                .client()
                .output_ids(OutputQueryParameters::new().unlockable_by_address(address.clone()))
                .await?
                .items);

Links to any relevant issues

Fixes #2103

How the change has been tested

Syncing a wallet with

{
        syncImplicitAccounts: true,
        wallet: { nftOutputs: false },
    }

and || (address.is_implicit_account_creation() && sync_options.sync_implicit_accounts) above commented
still gets basic outputs with the implicit account creation address
DEBUG sdk/src/client/node_manager/http_client.rs:87 GET: 6 ms for 200 OK http://localhost:8050/api/indexer/v2/outputs/basic?unlockableByAddress=rms1yqfz7u5aau3gkhx62kp4a2fct3wt5tmw52pz6qyy4vatm7yl3k52c94v4ts

@Thoralf-M Thoralf-M marked this pull request as ready for review March 5, 2024 19:55
@Thoralf-M Thoralf-M marked this pull request as draft March 5, 2024 19:58
@Thoralf-M Thoralf-M marked this pull request as ready for review March 5, 2024 20:14
@thibault-martinez thibault-martinez merged commit 182692e into iotaledger:2.0 Mar 6, 2024
37 checks passed
@Thoralf-M Thoralf-M deleted the implicit-account-creation-address-sync-options branch March 6, 2024 16:35
Thoralf-M added a commit to Thoralf-M/iota-sdk that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants