feat(wallet-dashboard): Improve assets filter #4512

panteleymonchuk · 2024-12-16T18:27:49Z

Links to any relevant issues

How to test

As show/hide for asset doesn't work in the dashboard, for testing we assign
ownedAssets?.visual.length to zero

in the file: apps/wallet-dashboard/app/(protected)/assets/page.tsx:

eg

useEffect(() => {
        let computeSelectedCategory = false;
        if (ownedAssets) {
          ownedAssets.visual.length = 0
        }
        if (
            (selectedCategory === AssetCategory.Visual && ownedAssets?.visual.length === 0) ||
            (selectedCategory === AssetCategory.Other && ownedAssets?.other.length === 0) ||
            !selectedCategory
        ) {
        ...

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes

… notifications

…otifications

…hing

github-actions · 2024-12-16T18:29:38Z

This pull request has been deployed to Vercel.

Latest commit: 5137f19

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-lgskid491.vercel.app

github-actions · 2024-12-16T18:29:50Z

This pull request has been deployed to Vercel.

Latest commit: 5137f19

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-r3kgy2afx.vercel.app

github-actions · 2024-12-16T18:30:03Z

This pull request has been deployed to Vercel.

Latest commit: 5137f19

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-6cws11ims.vercel.app

…improve-asset-filter

github-actions · 2024-12-17T10:52:20Z

This pull request has been deployed to Vercel.

Latest commit: 5185c8d

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-anz4omz5z.vercel.app

github-actions · 2024-12-17T10:52:24Z

This pull request has been deployed to Vercel.

Latest commit: 5185c8d

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-953iz8cwk.vercel.app

github-actions · 2024-12-17T10:52:49Z

This pull request has been deployed to Vercel.

Latest commit: 5185c8d

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-f6mf3hoqo.vercel.app

apps/wallet-dashboard/app/(protected)/assets/page.tsx

github-actions · 2024-12-18T09:04:36Z

This pull request has been deployed to Vercel.

Latest commit: 70752dd

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-imbr8amxh.vercel.app

github-actions · 2024-12-18T09:04:51Z

This pull request has been deployed to Vercel.

Latest commit: 70752dd

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-72qrl6hma.vercel.app

github-actions · 2024-12-18T09:14:35Z

This pull request has been deployed to Vercel.

Latest commit: 73f2001

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-iqfkg9y99.vercel.app

github-actions · 2024-12-18T09:14:40Z

This pull request has been deployed to Vercel.

Latest commit: 73f2001

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-9xcwnbhxh.vercel.app

github-actions · 2024-12-18T09:15:01Z

This pull request has been deployed to Vercel.

Latest commit: 73f2001

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-7ogwuaqsx.vercel.app

evavirseda

🙏

apps/wallet-dashboard/app/(protected)/assets/layout.tsx

apps/wallet-dashboard/app/(protected)/assets/page.tsx

…ct asset logic.

…ate assets logic

github-actions · 2025-01-09T20:38:18Z

This pull request has been deployed to Vercel.

Latest commit: 6c44bc4

✅ Preview: https://apps-ui-okkr68ogv-iota1.vercel.app

github-actions · 2025-01-09T20:38:41Z

This pull request has been deployed to Vercel.

Latest commit: 6c44bc4

✅ Preview: https://apps-backend-eu419csze-iota1.vercel.app

github-actions · 2025-01-09T20:38:53Z

This pull request has been deployed to Vercel.

Latest commit: 6c44bc4

✅ Preview: https://rebased-explorer-9a0x2tp84-iota1.vercel.app

github-actions · 2025-01-09T20:39:10Z

This pull request has been deployed to Vercel.

Latest commit: 6c44bc4

✅ Preview: https://wallet-dashboard-8dmdzc1nj-iota1.vercel.app

VmMad

lgtm

github-actions · 2025-01-10T10:50:50Z

This pull request has been deployed to Vercel.

Latest commit: 96168f3

✅ Preview: https://rebased-explorer-7ahgkk5t6-iota1.vercel.app

github-actions · 2025-01-10T10:52:06Z

This pull request has been deployed to Vercel.

Latest commit: 96168f3

✅ Preview: https://apps-ui-4jtd8vq38-iota1.vercel.app

github-actions · 2025-01-10T10:53:00Z

This pull request has been deployed to Vercel.

Latest commit: 96168f3

✅ Preview: https://apps-backend-a8wl4opi6-iota1.vercel.app

github-actions · 2025-01-10T10:53:21Z

This pull request has been deployed to Vercel.

Latest commit: 96168f3

✅ Preview: https://wallet-dashboard-1agwdt27r-iota1.vercel.app

github-actions · 2025-01-10T13:05:37Z

This pull request has been deployed to Vercel.

Latest commit: 25de57e

✅ Preview: https://apps-ui-edao2fh98-iota1.vercel.app

github-actions · 2025-01-10T13:05:55Z

This pull request has been deployed to Vercel.

Latest commit: 25de57e

✅ Preview: https://apps-backend-go56o69sq-iota1.vercel.app

github-actions · 2025-01-10T13:06:15Z

This pull request has been deployed to Vercel.

Latest commit: 25de57e

✅ Preview: https://rebased-explorer-jrk64vfb7-iota1.vercel.app

github-actions · 2025-01-10T13:06:42Z

This pull request has been deployed to Vercel.

Latest commit: 25de57e

✅ Preview: https://wallet-dashboard-rod7d4whc-iota1.vercel.app

apps/core/src/hooks/ui/usePageAssets.ts

github-actions · 2025-01-10T17:33:31Z

This pull request has been deployed to Vercel.

Latest commit: dd69e67

✅ Preview: https://apps-ui-ah7lgymh8-iota1.vercel.app

github-actions · 2025-01-10T17:33:45Z

This pull request has been deployed to Vercel.

Latest commit: dd69e67

✅ Preview: https://apps-backend-afn3pmlxh-iota1.vercel.app

github-actions · 2025-01-10T17:33:59Z

This pull request has been deployed to Vercel.

Latest commit: dd69e67

✅ Preview: https://rebased-explorer-3gomiyzmz-iota1.vercel.app

github-actions · 2025-01-10T17:34:50Z

This pull request has been deployed to Vercel.

Latest commit: dd69e67

✅ Preview: https://wallet-dashboard-mpvge4n57-iota1.vercel.app

* refactor(wallet): move notification to separate component. * feat(wallet): enhance hidden asset functionality with undo option and notifications * feat(wallet): add undo functionality for showing hidden assets with notifications * feat(core): move HiddenAssetsProvider. * feat(core): move useGetNFTs. * feat(core): update useGetNFTs to accept filter and improve asset fetching * refactor(dashboard): remove 'Hidden' asset category and related logic * refactor(wallet-dashboard): remove 'Hidden' asset category from layout * refactor(dashboard): remove HiddenAssets context, update default select asset logic. * feat(core): add refetch capability to useGetNFTs hook * refactor(core): improve hide/show logic * refactor(core): remove undo functionality and streamline asset visibility management * refactor(core): simplify asset visibility management and improve error handling * refactor(wallet): rename MoveAssetNotification to MovedAssetNotification * refactor(dashboard): adapt logic to useGetNFTs hook. * fix(wallet-dashboard): improve asset loading logic and conditional rendering * feat(wallet-dashboard): move logic for page to the hook * fix(dashboard): load more if we have intersection * feat(ui-kit, dashboard): add disabled state to Chip component and update assets logic * refactor(core): reorganize usePageAssets hook into ui directory * refactor(core): move filter from param to hook direct.

panteleymonchuk added 6 commits December 16, 2024 18:55

refactor(wallet): move notification to separate component.

bf71636

feat(wallet): enhance hidden asset functionality with undo option and…

bc69f2f

… notifications

feat(wallet): add undo functionality for showing hidden assets with n…

351bfe4

…otifications

feat(core): move HiddenAssetsProvider.

a7a42f7

feat(core): move useGetNFTs.

0b491ad

feat(core): update useGetNFTs to accept filter and improve asset fetc…

5137f19

…hing

panteleymonchuk requested a review from a team as a code owner December 16, 2024 18:27

iota-ci added the tooling Issues related to the Tooling team label Dec 16, 2024

panteleymonchuk added wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp labels Dec 16, 2024

Merge remote-tracking branch 'origin/develop' into tooling-dashboard/…

5185c8d

…improve-asset-filter

evavirseda requested changes Dec 17, 2024

View reviewed changes

apps/wallet-dashboard/app/(protected)/assets/page.tsx Outdated Show resolved Hide resolved

apps/wallet-dashboard/app/(protected)/assets/page.tsx Outdated Show resolved Hide resolved

begonaalvarezd changed the title ~~feat(dashboard): Improve assets filter~~ feat(wallet-dashboard): Improve assets filter Dec 18, 2024

refactor(dashboard): remove 'Hidden' asset category and related logic

70752dd

panteleymonchuk requested review from evavirseda and begonaalvarezd December 18, 2024 09:03

refactor(wallet-dashboard): remove 'Hidden' asset category from layout

73f2001

evavirseda requested changes Dec 18, 2024

View reviewed changes

apps/wallet-dashboard/app/(protected)/assets/layout.tsx Outdated Show resolved Hide resolved

apps/wallet-dashboard/app/(protected)/assets/page.tsx Outdated Show resolved Hide resolved

apps/wallet-dashboard/app/(protected)/assets/page.tsx Outdated Show resolved Hide resolved

refactor(dashboard): remove HiddenAssets context, update default sele…

9537c65

…ct asset logic.

feat(ui-kit, dashboard): add disabled state to Chip component and upd…

6c44bc4

…ate assets logic

github-actions bot added the apps-ui-kit Issues related to the Apps UI Kit label Jan 9, 2025

panteleymonchuk requested a review from VmMad January 9, 2025 20:37

VmMad approved these changes Jan 10, 2025

View reviewed changes

Merge branch 'develop' into tooling-dashboard/improve-asset-filter

96168f3

refactor(core): reorganize usePageAssets hook into ui directory

25de57e

begonaalvarezd requested changes Jan 10, 2025

View reviewed changes

apps/core/src/hooks/ui/usePageAssets.ts Outdated Show resolved Hide resolved

refactor(core): move filter from param to hook direct.

7c4f517

panteleymonchuk requested a review from begonaalvarezd January 10, 2025 17:31

Merge branch 'develop' into tooling-dashboard/improve-asset-filter

dd69e67

begonaalvarezd approved these changes Jan 10, 2025

View reviewed changes

begonaalvarezd merged commit a15a205 into develop Jan 10, 2025
35 checks passed

begonaalvarezd deleted the tooling-dashboard/improve-asset-filter branch January 10, 2025 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(wallet-dashboard): Improve assets filter #4512

feat(wallet-dashboard): Improve assets filter #4512

panteleymonchuk commented Dec 16, 2024 •

edited

Loading

github-actions bot commented Dec 16, 2024

github-actions bot commented Dec 16, 2024

github-actions bot commented Dec 16, 2024

github-actions bot commented Dec 17, 2024

github-actions bot commented Dec 17, 2024

github-actions bot commented Dec 17, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

evavirseda left a comment

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

VmMad left a comment

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

feat(wallet-dashboard): Improve assets filter #4512

feat(wallet-dashboard): Improve assets filter #4512

Conversation

panteleymonchuk commented Dec 16, 2024 • edited Loading

Links to any relevant issues

How to test

Change checklist

github-actions bot commented Dec 16, 2024

github-actions bot commented Dec 16, 2024

github-actions bot commented Dec 16, 2024

github-actions bot commented Dec 17, 2024

github-actions bot commented Dec 17, 2024

github-actions bot commented Dec 17, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 18, 2024

evavirseda left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

VmMad left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

panteleymonchuk commented Dec 16, 2024 •

edited

Loading