Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Add support for arm64 and amd64 builds for jemalloc #4585

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Dec 20, 2024

Description of change

There was a hardcoded path in the LD_PRELOAD environment variable for x86_64-linux-gnu architecture, which makes no sense for arm64. This PR installs libjemalloc on arm64 and amd64 plattforms and correctly symlinks the library to a static path, which then is used in the LD_PRELOAD env var. On other architectures we panic the docker build now.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

I created a PoC dockerfile and checked the env vars after the build.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@muXxer muXxer requested review from a team as code owners December 20, 2024 12:41
@iota-ci iota-ci added core-protocol node Issues related to the Core Node team labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants