Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): improve fetching visual assets on higher numbered pages #4591

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

brancoder
Copy link
Contributor

Description of change

resolves #4532

How the change has been tested

  1. add new mnemonic to wallet and tooling resources .env to have a clean start
  2. in tooling resources create a lot of non coin objects
    ex. create stardust basic outputs with run-test-scenario script but MODIFY the script before running it by commenting out the creation of Nft outputs and alias outputs. Even the native tokens can be removed from basic outputs to keep things simple.
    Run the modified script couple of times so you generate more than 50 basic output objects.
  3. mint single NFT with pnpm mint_nft:mint and in this way the NFT would appear in 2. or 3. page

@brancoder brancoder added tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet labels Dec 20, 2024
@brancoder brancoder requested a review from a team as a code owner December 20, 2024 14:45
@begonaalvarezd begonaalvarezd merged commit daee547 into develop Dec 26, 2024
35 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-wallet/improve-fetching-visual-assets branch December 26, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix visual assets not showing in wallet with large portfolios
3 participants