feat(iota): Add shell completions #4608
Open
+140
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iota-ci
added
dev-tools
thibault-martinez
requested changes
Dec 23, 2024
|
I would put this behind a feature flag and only use that feature when we release binaries to generate the completions. |
I think that's reasonable. |
oop Co-authored-by: Thibault Martinez <[email protected]>
| @@ -363,6 +363,8 @@ pub enum IotaCommand { | |||
| /// Invoke Iota's move-analyzer via CLI | |||
| #[clap(name = "analyzer", hide = true)] | |||
| Analyzer, | |||
| #[cfg(feature = "gen-completions")] | |||
| GenerateCompletions(crate::completions::CompletionCommand), | |||
There was a problem hiding this comment.
kinda bothers me that the command variant doesn't match the command type
There was a problem hiding this comment.
If anyone else wants to change this, vote here 😆 It doesn't bother me, personally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds the ability to generate shell completion files using
clap_completionto the CLI. These files are also included in these changes. Let me know if you think these should be checked in, or whether users should be required to generate them themselves. Of course, if they are checked it they must be updated whenever the CLI changes. This could be checked in CI.Links to any relevant issues
Closes #4495