New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tooling): remove unnecessary `import React from 'react'` #4612

Merged

begonaalvarezd merged 13 commits into develop from tooling/remove-unnecessary-import-react

Jan 8, 2025

Contributor

evavirseda commented Dec 24, 2024

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #4371

Type of change

Choose a type of change, and delete any options that are not relevant.

Bug fix (a non-breaking change which fixes an issue)
Enhancement (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes


          feat: remove unnecessary react import

a653fee

evavirseda requested a review from a team as a code owner

December 24, 2024 08:23

evavirseda self-assigned this

github-actions bot added the explorer label

iota-ci added the tooling label

evavirseda removed the explorer label

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: a653fee

✅ Preview: https://apps-ui-5objsv8ez-iota1.vercel.app

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: a653fee

✅ Preview: https://apps-backend-ozs6ie861-iota1.vercel.app


          fix: remove debris

bd2d796

github-actions bot added the explorer label

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: bd2d796

✅ Preview: https://apps-ui-cz2hlhinn-iota1.vercel.app

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: bd2d796

✅ Preview: https://apps-backend-9tn3n5bc2-iota1.vercel.app


          fix import

ac22dd3

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: ac22dd3

✅ Preview: https://apps-ui-q38iiigbw-iota1.vercel.app

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: ac22dd3

✅ Preview: https://apps-backend-32gxqr1ij-iota1.vercel.app

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: ac22dd3

✅ Preview: https://rebased-explorer-j6a379rxx-iota1.vercel.app


          feat: cleanup

f728065

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: ac22dd3

✅ Preview: https://wallet-dashboard-cd5lhgkia-iota1.vercel.app

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: f728065

✅ Preview: https://apps-backend-pxuzcnd7e-iota1.vercel.app

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: f728065

✅ Preview: https://apps-ui-plzek32c4-iota1.vercel.app

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: f728065

✅ Preview: https://rebased-explorer-cfm09l9gd-iota1.vercel.app

Contributor

github-actions bot commented Dec 24, 2024

This pull request has been deployed to Vercel.

Latest commit: f728065

✅ Preview: https://wallet-dashboard-jmmcuaonk-iota1.vercel.app


          Merge branch 'develop' into tooling/remove-unnecessary-import-react

42625d3

Contributor

github-actions bot commented Dec 26, 2024

This pull request has been deployed to Vercel.

Latest commit: 42625d3

✅ Preview: https://apps-ui-6mjse228v-iota1.vercel.app

Contributor

github-actions bot commented Dec 26, 2024

This pull request has been deployed to Vercel.

Latest commit: 42625d3

✅ Preview: https://rebased-explorer-4jd6ilwew-iota1.vercel.app

Contributor

github-actions bot commented Dec 26, 2024

This pull request has been deployed to Vercel.

Latest commit: 42625d3

✅ Preview: https://apps-backend-ltq76etcv-iota1.vercel.app

Contributor

github-actions bot commented Dec 26, 2024

This pull request has been deployed to Vercel.

Latest commit: 42625d3

✅ Preview: https://wallet-dashboard-g36svylby-iota1.vercel.app

begonaalvarezd requested changes

View reviewed changes

Member

begonaalvarezd left a comment •

edited

Loading

There are still more import react in the codebase, note that not all can be removed because some are necessary like in the dapps and the SDK


          feat: remove debris and add tsconfig

8e614f5

github-actions bot added the apps-ui-kit label


          Merge branch 'develop' into tooling/remove-unnecessary-import-react

d4610f8

Contributor

github-actions bot commented Dec 27, 2024

This pull request has been deployed to Vercel.

Latest commit: d4610f8

✅ Preview: https://apps-ui-bom2womjj-iota1.vercel.app

Contributor

github-actions bot commented Dec 27, 2024

This pull request has been deployed to Vercel.

Latest commit: d4610f8

✅ Preview: https://rebased-explorer-ek8ifk2z9-iota1.vercel.app

Contributor

github-actions bot commented Dec 27, 2024

This pull request has been deployed to Vercel.

Latest commit: d4610f8

✅ Preview: https://apps-backend-f6v753bx0-iota1.vercel.app

Contributor

github-actions bot commented Dec 27, 2024

This pull request has been deployed to Vercel.

Latest commit: d4610f8

✅ Preview: https://wallet-dashboard-ll4dlsx1l-iota1.vercel.app


          Merge branch 'develop' into tooling/remove-unnecessary-import-react

Contributor

github-actions bot commented Dec 30, 2024

This pull request has been deployed to Vercel.

Latest commit: 4234034

✅ Preview: https://rebased-explorer-21oaq23rv-iota1.vercel.app

Contributor

github-actions bot commented Dec 30, 2024

This pull request has been deployed to Vercel.

Latest commit: 4234034

✅ Preview: https://apps-backend-lrnllyngy-iota1.vercel.app

Contributor

github-actions bot commented Dec 30, 2024

This pull request has been deployed to Vercel.

Latest commit: 4234034

✅ Preview: https://apps-ui-g5ii61e5n-iota1.vercel.app

Contributor

github-actions bot commented Dec 30, 2024

This pull request has been deployed to Vercel.

Latest commit: 4234034

✅ Preview: https://wallet-dashboard-cnrfj7g97-iota1.vercel.app


          Merge branch 'develop' into tooling/remove-unnecessary-import-react

7174d46

Contributor

github-actions bot commented Jan 2, 2025

This pull request has been deployed to Vercel.

Latest commit: 7174d46

✅ Preview: https://apps-ui-kch7jg2q9-iota1.vercel.app

Contributor

github-actions bot commented Jan 2, 2025

This pull request has been deployed to Vercel.

Latest commit: 7174d46

✅ Preview: https://rebased-explorer-hzspfyjal-iota1.vercel.app

Contributor

github-actions bot commented Jan 2, 2025

This pull request has been deployed to Vercel.

Latest commit: 7174d46

✅ Preview: https://apps-backend-71g39h6v4-iota1.vercel.app

Contributor

github-actions bot commented Jan 2, 2025

This pull request has been deployed to Vercel.

Latest commit: 7174d46

✅ Preview: https://wallet-dashboard-pib7r6e8k-iota1.vercel.app

VmMad approved these changes

View reviewed changes

Member

VmMad left a comment

🚀


          Merge branch 'develop' into tooling/remove-unnecessary-import-react

2c2c9a8

Contributor

github-actions bot commented Jan 3, 2025

This pull request has been deployed to Vercel.

Latest commit: 2c2c9a8

✅ Preview: https://apps-backend-owsagnlxv-iota1.vercel.app

Contributor

github-actions bot commented Jan 3, 2025

This pull request has been deployed to Vercel.

Latest commit: 2c2c9a8

✅ Preview: https://rebased-explorer-52do1f7hy-iota1.vercel.app

Contributor

github-actions bot commented Jan 3, 2025

This pull request has been deployed to Vercel.

Latest commit: 2c2c9a8

✅ Preview: https://apps-ui-nogx6g2i1-iota1.vercel.app

Contributor

github-actions bot commented Jan 3, 2025

This pull request has been deployed to Vercel.

Latest commit: 2c2c9a8

✅ Preview: https://wallet-dashboard-5detjwx1g-iota1.vercel.app


          Merge branch 'develop' into tooling/remove-unnecessary-import-react

37f18a3

Contributor

github-actions bot commented Jan 3, 2025

This pull request has been deployed to Vercel.

Latest commit: 37f18a3

✅ Preview: https://apps-ui-p3ft4ldeu-iota1.vercel.app

Contributor

github-actions bot commented Jan 3, 2025

This pull request has been deployed to Vercel.

Latest commit: 37f18a3

✅ Preview: https://apps-backend-cbc5nyqc5-iota1.vercel.app

Contributor

github-actions bot commented Jan 3, 2025

This pull request has been deployed to Vercel.

Latest commit: 37f18a3

✅ Preview: https://rebased-explorer-jfzpw15fh-iota1.vercel.app

Contributor

github-actions bot commented Jan 3, 2025

This pull request has been deployed to Vercel.

Latest commit: 37f18a3

✅ Preview: https://wallet-dashboard-hie51ymu6-iota1.vercel.app

begonaalvarezd changed the title ~~feat(tooling): remove unnecessary import React from 'react'~~ refactor(tooling): remove unnecessary import React from 'react'

begonaalvarezd approved these changes

View reviewed changes

begonaalvarezd merged commit 4012345 into develop

35 checks passed

begonaalvarezd deleted the tooling/remove-unnecessary-import-react branch

January 8, 2025 11:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apps-backend apps-ui-kit explorer tooling wallet wallet-dashboard