Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(wallet, explorer, dashboard): change default export for components #4617

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

refactor(wallet, explorer, dashboard): change default export for components #4617

wants to merge 4 commits into from

Conversation

panteleymonchuk
Copy link
Contributor

Links to any relevant issues

Closes #4375

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@panteleymonchuk panteleymonchuk added tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet explorer Issues related to the Explorer wallet-dashboard Issues related to the Wallet Dashboard dApp labels Dec 24, 2024
@panteleymonchuk panteleymonchuk requested a review from a team as a code owner December 24, 2024 12:31
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8cf12c3

✅ Preview: https://apps-backend-gpww5odp7-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8cf12c3

✅ Preview: https://apps-ui-iijriwkil-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8cf12c3

✅ Preview: https://rebased-explorer-dak0agztx-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 02952d4

✅ Preview: https://apps-ui-pesrqf21z-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 02952d4

✅ Preview: https://rebased-explorer-medsoaabn-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 02952d4

✅ Preview: https://apps-backend-7qjnfdise-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 02952d4

✅ Preview: https://wallet-dashboard-42cpkwr6j-iota1.vercel.app

evavirseda
evavirseda requested changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, these files need to be updated too:
apps/wallet/src/ui/app/helpers/index.ts
apps/wallet/src/ui/app/hooks/index.ts
🙏 🙏

apps/explorer/src/components/header/Header.tsx
@@ -3,12 +3,12 @@
// SPDX-License-Identifier: Apache-2.0

import { NetworkSelector } from '../network';
import Search from '../search/Search';
import { Search } from '../search/Search';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { Search } from '../search/Search';
import { Search } from '../search';

apps/explorer/src/components/layout/PageLayout.tsx
Comment on lines +10 to +11
import { Footer } from '../footer/Footer';
import { Header } from '../header/Header';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { Footer } from '../footer/Footer';
import { Header } from '../header/Header';
import { Footer, Header } from '..';

apps/explorer/src/components/ui/image/Image.tsx
@@ -9,7 +9,7 @@ import clsx from 'clsx';
import { useAnimate } from 'framer-motion';
import { type ImgHTMLAttributes, useEffect, useState } from 'react';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

apps/explorer/src/components/ui/image/Image.tsx
@@ -9,7 +9,7 @@ import clsx from 'clsx';
import { useAnimate } from 'framer-motion';
import { type ImgHTMLAttributes, useEffect, useState } from 'react';

import useImage from '~/hooks/useImage';
import { useImage } from '~/hooks/useImage';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { useImage } from '~/hooks/useImage';
import { useImage } from '~/hooks';

apps/explorer/src/pages/object-result/ObjectResult.tsx
Comment on lines +11 to 12
import { PkgView } from './views/PkgView';
import { TokenView } from './views/TokenView';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add an index.ts file to organize these imports? that way, we can simplify them like this:

Suggested change
import { PkgView } from './views/PkgView';
import { TokenView } from './views/TokenView';
import { PkgView, TokenView } from './views';

apps/wallet/src/ui/app/index.tsx
@@ -68,7 +69,7 @@ const HIDDEN_MENU_PATHS = [

const NOTIFY_USER_ACTIVE_INTERVAL = 5 * 1000; // 5 seconds

const App = () => {
export const App = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const App = () => {
export function App() {

apps/wallet/src/ui/app/pages/home/index.tsx
@@ -11,7 +11,7 @@ interface HomePageProps {
disableNavigation?: boolean;
}

const HomePage = ({ disableNavigation }: HomePageProps) => {
export const HomePage = ({ disableNavigation }: HomePageProps) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const HomePage = ({ disableNavigation }: HomePageProps) => {
export function HomePage({ disableNavigation }: HomePageProps) {

apps/wallet/src/ui/app/pages/home/tokens/TokensDetails.tsx
Comment on lines +35 to +36
import { Interstitial } from '../interstitial';
import { type InterstitialConfig } from '../interstitial';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { Interstitial } from '../interstitial';
import { type InterstitialConfig } from '../interstitial';
import { Interstitial, type InterstitialConfig } from '../interstitial';

apps/wallet/src/ui/app/pages/home/tokens/index.tsx
@@ -4,16 +4,14 @@

import { Route, Routes } from 'react-router-dom';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

apps/wallet/src/ui/index.tsx
@@ -23,7 +23,7 @@ import { createRoot } from 'react-dom/client';
import { Provider } from 'react-redux';
import { HashRouter } from 'react-router-dom';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
explorer Issues related to the Explorer tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup default exports for any component files
2 participants
@panteleymonchuk @evavirseda