Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet-dashboard): number of different native tokens in migration summary #4619

Merged
merged 15 commits into from
Jan 9, 2025
Merged

fix(wallet-dashboard): number of different native tokens in migration summary #4619

merged 15 commits into from
Jan 9, 2025

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #4578

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda self-assigned this Dec 24, 2024
@evavirseda evavirseda added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Dec 24, 2024
@evavirseda evavirseda marked this pull request as ready for review December 26, 2024 08:25
@evavirseda evavirseda requested a review from a team as a code owner December 26, 2024 08:25
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 60843a7

✅ Preview: https://wallet-dashboard-dl8s0uokm-iota1.vercel.app

@begonaalvarezd begonaalvarezd changed the title feat(wallet-dashboard): fix number of native tokens in migration summary fix(wallet-dashboard): number of native tokens in migration summary Dec 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 075c8d0

✅ Preview: https://wallet-dashboard-pjzrpyfg3-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 11d293e

✅ Preview: https://wallet-dashboard-jb7xo8qoi-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 552ee88

✅ Preview: https://wallet-dashboard-r8veh8jeh-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

This pull request has been deployed to Vercel.

Latest commit: 42d253c

✅ Preview: https://wallet-dashboard-r8987f9fj-iota1.vercel.app

VmMad
VmMad previously approved these changes Jan 2, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This pull request has been deployed to Vercel.

Latest commit: ab2d262

✅ Preview: https://wallet-dashboard-jrs2cd8uw-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has been deployed to Vercel.

Latest commit: d39d92e

✅ Preview: https://rebased-explorer-7gsisz1q8-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has been deployed to Vercel.

Latest commit: d39d92e

✅ Preview: https://apps-ui-9zatjcgla-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has been deployed to Vercel.

Latest commit: d39d92e

✅ Preview: https://wallet-dashboard-cr2imllzm-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has been deployed to Vercel.

Latest commit: d39d92e

✅ Preview: https://apps-backend-h7d5wd5ef-iota1.vercel.app

@begonaalvarezd begonaalvarezd changed the title fix(wallet-dashboard): number of native tokens in migration summary fix(wallet-dashboard): number of different native tokens in migration summary Jan 8, 2025
@begonaalvarezd begonaalvarezd dismissed VmMad’s stale review January 8, 2025 15:15

refactor pushed after approve, please review again

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has been deployed to Vercel.

Latest commit: 11b1d42

✅ Preview: https://wallet-dashboard-q2fx6ggq2-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has been deployed to Vercel.

Latest commit: 0eeba79

✅ Preview: https://wallet-dashboard-ghwgtfpim-iota1.vercel.app

VmMad
VmMad approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This pull request has been deployed to Vercel.

Latest commit: 2619f71

✅ Preview: https://wallet-dashboard-fie6clu1c-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This pull request has been deployed to Vercel.

Latest commit: 1f39da9

✅ Preview: https://wallet-dashboard-e91f7yx1y-iota1.vercel.app

@cpl121 cpl121 merged commit 2fcc992 into develop Jan 9, 2025
35 checks passed
@cpl121 cpl121 deleted the tooling-dashboard/fix-number-of-native-tokens-in-migration-summary branch January 9, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@VmMad VmMad VmMad approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees

@evavirseda evavirseda

Labels
tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix number of native tokens in migration summary
4 participants
@evavirseda @begonaalvarezd @VmMad @cpl121