feat(nodeconfig)!: Default to Bech32 format for IOTA key pairs #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
iota-ci
added
dev-tools
DaughterOfMars
approved these changes
Jan 21, 2025
Thoralf-M
reviewed
Jan 27, 2025
Co-authored-by: Thoralf-M <[email protected]>
muXxer
approved these changes
Jan 28, 2025
muXxer
reviewed
Jan 28, 2025
crates/iota-swarm-config/tests/snapshots/snapshot_tests__network_config_snapshot_matches.snap
Show resolved
Hide resolved
Thoralf-M
changed the title
thibault-martinez
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Changes the custom serialization/deserialization methods to default to Bech32. Serializes always to Bech32, but tries to deserialize from Bech32 first and if that fails, attempts to deserialize from Base64.
Links to any relevant issues
fixes #3985
How the change has been tested
I checked through a separate python script that the swapped strings (Base32/Base64) in the
.snapfile actually represent the same private keys.