-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(indexer): Derive dynamic field info #5073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
iota-ci
added
infrastructure
Issues related to the Infrastructure Team
sc-platform
Issues related to the Smart Contract Platform group.
labels
Jan 28, 2025
tomxey
changed the title
indexer: derive dynamic field info
refactor(indexer): derive dynamic field info
Jan 31, 2025
tomxey
changed the title
refactor(indexer): derive dynamic field info
refactor(indexer): Derive dynamic field info
Jan 31, 2025
kodemartin
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with minor comments
sergiupopescu199
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🐝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
infrastructure
Issues related to the Infrastructure Team
sc-platform
Issues related to the Smart Contract Platform group.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Pull from upstream: MystenLabs/sui#19099
Refactors way that dynamic fields are obtained in indexer api, to not use
df_object_id
,df_name
,df_object_type
columns in preparation for their removal.Links to any relevant issues
fixes #5049
Type of change
How the change has been tested
cargo test --package=iota-indexer --profile=simulator --features=shared_test_runtime
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.