Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(indexer): Derive dynamic field info #5073

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

tomxey
Copy link
Contributor

@tomxey tomxey commented Jan 28, 2025

Description of change

Pull from upstream: MystenLabs/sui#19099

Refactors way that dynamic fields are obtained in indexer api, to not use df_object_id, df_name, df_object_type columns in preparation for their removal.

Links to any relevant issues

fixes #5049

Type of change

  • Refactoring

How the change has been tested

cargo test --package=iota-indexer --profile=simulator --features=shared_test_runtime

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@tomxey tomxey self-assigned this Jan 28, 2025
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 10:16am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 10:16am
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 10:16am
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 10:16am

@iota-ci iota-ci added infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group. labels Jan 28, 2025
@tomxey tomxey marked this pull request as ready for review January 29, 2025 10:48
@tomxey tomxey requested a review from a team as a code owner January 29, 2025 10:48
@tomxey tomxey changed the title indexer: derive dynamic field info refactor(indexer): derive dynamic field info Jan 31, 2025
@tomxey tomxey changed the title refactor(indexer): derive dynamic field info refactor(indexer): Derive dynamic field info Jan 31, 2025
Copy link
Contributor

@kodemartin kodemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with minor comments

crates/iota-indexer/src/indexer_reader.rs Outdated Show resolved Hide resolved
crates/iota-indexer/src/indexer_reader.rs Outdated Show resolved Hide resolved
crates/iota-indexer/src/indexer_reader.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@sergiupopescu199 sergiupopescu199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🐝

@tomxey tomxey merged commit 5717f57 into develop Feb 5, 2025
41 checks passed
@tomxey tomxey deleted the sc-platform/derive-dynamic-field-info branch February 5, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

indexer reader: derive dynamic field info
4 participants