libbpf-tools: Allow tools to run on old kernels #4546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallback to use kprobes if kernel lacks support for fentry/fexit. Signed-off-by: mickey_zhu <[email protected]>
michael-chuh
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
chenhengqi
reviewed
Apr 4, 2023
Comment on lines
+70
to
+71
| static __always_inline | ||
| int trace_done(void *ctx, struct request *rq) |
There was a problem hiding this comment.
Keep this in single line. We don't need __always_inline here.
|
|
||
| SEC("fexit/__page_cache_alloc") | ||
| int BPF_PROG(page_cache_alloc_ret, gfp_t gfp, struct page *ret) | ||
| static __always_inline |
|
Close this in favor of new ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more tools to fallback to use kprobes if kernel lacks support for fentry/fexit,
discussion is on #4231