feat: add webrtc-direct support #42
Conversation
aschmahmann
force-pushed
the
feat/add-webrtcdirect
branch
from
05abf1d
to
0fb0634
Compare
| ) | ||
|
|
||
| func libp2pHost() (host.Host, error) { | ||
| h, err := libp2p.New(libp2p.DefaultMuxers, libp2p.Muxer("/mplex/6.7.0", mplex.DefaultTransport), libp2p.EnableHolePunching()) | ||
| h, err := libp2p.New(libp2p.DefaultTransports, libp2p.Transport(libp2pwebrtc.New), libp2p.DefaultMuxers, libp2p.Muxer("/mplex/6.7.0", mplex.DefaultTransport), libp2p.EnableHolePunching()) |
There was a problem hiding this comment.
@MarcoPolo any downsides here? This will disable listen addresses, but that seems fine (even though it'll prevent dialbacks if the node is publicly reachable). Perhaps we should even have been doing that explicitly or enabling the user to pass a listen address if they want dialbacks to work.
There was a problem hiding this comment.
This might break hole-punching too.
There was a problem hiding this comment.
Why would this break hole-punching?
Isn't this a problem then now that we have webrtc enabled by default?
There was a problem hiding this comment.
The issue is that adding a transport will disable the default listen addresses so we'd have to pass them in manually (of course still very doable) and the lack of listen addresses would cause problems with the holepunching.
|
WebRTC Direct is enabled by default in go-libp2p so this will be replaced by #45 |
No description provided.