Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unresponsive content providers, update with new ones, and sort #1837

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

acejam
Copy link
Contributor

@acejam acejam commented Apr 5, 2024

Describe your changes

  • Stale and unresponsive peer IDs and multiaddresses have been removed from the list. These results were verified using DHT lookups and vole libp2p identify inspection.
  • The Filebase multiaddress was added
  • The list was alphabetically sorted

Files changed

  • docs/how-to/peering-with-content-providers.md

What issue(s) does this address?

IPFS Desktop and kubo users often attempt to peer with addresses on this list. This PR removes stale entries and ensures the currently listed entries are live.

Does this update depend on any other PRs?

It does not.

Checklist before requesting a review

  • Passing the beta version of the Check Markdown links for modified files check. Action results can be viewed here.

Checklist before merging

  • Passing all required checks (The beta Check Markdown links for modified files check is not required)

Copy link

welcome bot commented Apr 5, 2024

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
  • Your contribution itself is clear (grammar and spelling checked, any code blocks checked and commented) and in its best form. Follow the docs contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
  • The PR gets reviews, discussed and approvals as needed.
  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Member

@2color 2color left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up. Looks mostly good.

I left one comment on one of the removed nodes.

@acejam
Copy link
Contributor Author

acejam commented Apr 29, 2024

@2color Updates made based on feedback, this should be good for merge now.

@2color 2color merged commit c2577d1 into ipfs:main Apr 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants