-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete always skipped tests that used removed attributes, and unskip trio test #1322
base: main
Are you sure you want to change the base?
Conversation
da04e6e
to
48caeaa
Compare
Well that's strange, trio test passes locally... well on CI, anyio decides to switch in the middle of the call stack from trio to asyncio:
|
4d1770f
to
010bc5c
Compare
Well something else is wrong on CI, some pytest items are failing, but it's shown as green on 3.10: https://github.com/ipython/ipykernel/actions/runs/13292836924/job/37117594041?pr=1322 |
It's because we rerun last failed tests here. |
a1a86dc
to
acec02b
Compare
And try to fix trio tests
acec02b
to
6dd8fed
Compare
There are few chances we will ever use them again.
Also a small refactor and unskip of trio test using trio nursery.