timeout > 524 is not accurate #901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywc689
added
the
pr/to-review-codes
ywc689
reviewed
Aug 23, 2023
| hash = (sched->cursors[level] + off) % LEVEL_SIZE; | ||
| list_add_tail(&timer->list, &sched->hashs[level][hash]); | ||
| #ifdef CONFIG_TIMER_DEBUG | ||
| assert(timer->handler == handler); | ||
| #endif | ||
| return EDPVS_OK; | ||
| } else { | ||
| timer->delay += sched->cursors[level] * get_level_ticks(level); |
There was a problem hiding this comment.
timer->delay is an user-specified parameter, and we should not changed. It seems a carry-in problem. You may fix it in some other way.
There was a problem hiding this comment.
timer->delayis an user-specified parameter, and we should not changed. It seems a carry-in problem. You may fix it in some other way.
seems #29 fixed, but not merged
There was a problem hiding this comment.
Yes. I will reconsider it later.
ywc689
added
pr/codes-need-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.