hkd32: remove usage of zeroize_derive
#1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-iqlusion
force-pushed
the
hkd32/remove-zeroize-derive-usage
branch
from
e541254
to
6fa93ea
Compare
It's being used for trivial impls of the `zeroize` traits, and in the meantime `syn` MSRV changes are breaking the crate's current MSRV. The derived usages are trivially rewritten without the whole proc macro stack, and really these types shouldn't have `Zeroize` impls at all, but instead impl `Drop` and `ZeroizeOnDrop`.
tony-iqlusion
force-pushed
the
hkd32/remove-zeroize-derive-usage
branch
from
6fa93ea
to
ede9f28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's being used for trivial impls of the
zeroizetraits, and in the meantimesynMSRV changes are breaking the crate's current MSRV.The derived usages are trivially rewritten without the whole proc macro stack, and really these types shouldn't have
Zeroizeimpls at all, but instead implDropandZeroizeOnDrop.