Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vote extensions in CometBFT 0.38 or greater #835

Closed
zmanian opened this issue Jan 10, 2024 · 1 comment
Closed

Add support for vote extensions in CometBFT 0.38 or greater #835

zmanian opened this issue Jan 10, 2024 · 1 comment

Comments

@zmanian
Copy link
Contributor

zmanian commented Jan 10, 2024

Comet BFT adds two new fields to the Vote proto.

During the singing the extension field needs to be used to construct the canonical vote extension messages and then signed with the same signing algorithm as a normal vote message.

Vote extension fields

https://github.com/cometbft/cometbft/blob/main/proto/tendermint/types/types.proto#L138-L141

Message canonicalization
https://github.com/cometbft/cometbft/blob/main/types/vote.go#L156-L164

Implementation should solve #831

tony-iqlusion added a commit that referenced this issue Jan 11, 2024
When present, computes a secondary signature over `Vote::extension`.

Closes #831 #835
tony-iqlusion added a commit that referenced this issue Jan 11, 2024
When present, computes a secondary signature over `Vote::extension`.

Closes #831 #835
tony-iqlusion added a commit that referenced this issue Jan 12, 2024
When present, computes a secondary signature over `Vote::extension`.

Closes #831 #835
@tony-iqlusion
Copy link
Member

This was released in v0.13.1 (#845)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants