CanonicalVoteExtension signature support
#837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-iqlusion
force-pushed
the
canonical-vote-extension-support
branch
from
aca775a
to
ba851b9
Compare
|
it's running for ~15 minutes already, so far no issue. Will keep it for the night and observe logs UPDATE: I think it's working fine |
tony-iqlusion
changed the title
CanonicalVoteExtension signature supportCanonicalVoteExtension signature support
Shella
approved these changes
Jan 12, 2024
zmanian
approved these changes
Jan 12, 2024
Merged
melekes
reviewed
Feb 19, 2024
| match self { | ||
| Self::Proposal(_) => Ok(None), | ||
| Self::Vote(vote) => { | ||
| // Only sign extension if actually present |
There was a problem hiding this comment.
Even if vote.extension is empty, but vote extensions are enabled, the signature must be present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When present, computes a secondary signature over
Vote::extension.Closes #831 #835