-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add curve 25519 support #577
base: main
Are you sure you want to change the base?
Conversation
What is the status here? Doesn't look like a fundamental change, but it feels like it hasn't been reviewed in half a year 😕. |
I'm in the process of reviewing the PR, but can't test it effectively before #578 because the Yubikey firmware version that added Ed25519 support also changed management keys to use AES instead of DES. |
You can test on a YubiKey with 5.7 firmware by first setting the management key to the default TDES key. Assuming the default AES management key:
|
Yubico added support for curve 25519 in the PIV applet since firmware '5.7.X'. This support has already been added to yubico-piv-tool, but it is lacking in this Rust library. This PR is an attempt to keep the libraries aligned on functionality. Changes made are as described:
curve25519-dalek
crates added as dependenciesX25519
andEd25519
added as available algorithmsI'm open to any feedback. This is my first real go at production Rust code so criticism is welcome/needed for me to learn.
Additional items to maybe consider:
NotSupported
errors