support nitrokey 3 #595
Open
support nitrokey 3 #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to nist sp 800-73-4, section 2.2 the aid of the piv applet is A0 00 00 03 08 00 00 10 00 01 00 where A0 00 00 03 08 is the nist rid, 00 00 10 00 indicates the piv application, and 01 00 is the piv version tested with a yubikey 5c nfc which still works with this change, and with a nitrokey 3c which only responds to the full aid instead of just the prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure whether this is in the scope of this library, but with the nitrokey 3 firmware 1.8.0 it now supports a piv applet as well and it'd be nice to reuse this library for the nitrokey 3 as well.
supporting the key required two (probably minor) changes:
the nitrokey 3 also currently uses a static version (6.6.6) and serial (0x0052f743, 5437251), but supports the same commands as the yubikey 5.