Fix Failing CI Checks #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce some of the method parameters to be keyword-only parameters. This fixes pylint error from the newly (since v3.3.0) introduced check "too-many-positional-arguments"
rbrazinskas
requested review from
Aerylia,
jkotilahti,
kukushechkin,
smite and
ollityrkko
freetonik
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently released pylint v3.3.0 introduces new check of "too-many-positional-arguments". This makes the CI checks to fail. This PR changes method signature to comply with pylint recommendations.
Why did CI started failing all of a sudden? pylint version of the project is not pinned, only pytest-pylint is pinned to v0.21.0. pytest-pylint requires pylint as [requires: pylint>=2.15.0]. That's why the new version of pylint was installed by CI.