Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codegen][Tuner]: remove attrs inside decomposeConfig for attention op #20081

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

bangtianliu
Copy link
Contributor

@bangtianliu bangtianliu commented Feb 24, 2025

This PR follows up on #20072 to remove drop qk_attrs and pv_attrs inside DecompositionConfig, instead of completely removing DecompositionConfig.

Fixes #20053

@bangtianliu bangtianliu requested a review from hanhanW as a code owner February 24, 2025 20:31
@bangtianliu bangtianliu force-pushed the strip_attention_info_fix branch from bb8be9f to 852897f Compare February 24, 2025 20:38
Signed-off-by: Bangtian Liu <[email protected]>
@bangtianliu bangtianliu requested a review from kuhar February 24, 2025 22:47
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but let's wait from an approval from Kunwar

Signed-off-by: Bangtian Liu <[email protected]>
@bangtianliu bangtianliu requested a review from kuhar February 25, 2025 14:05
@bangtianliu bangtianliu merged commit 666cf34 into iree-org:main Feb 25, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make StripCompilationInfoPass to support the attention op
3 participants