Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ListEvents Runtime Interface to Support Cross-Cluster Events #570

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

ushabelgur
Copy link
Contributor

Proposed Changes

  • Add ListEvents implementation to volume provider
  • Add event recorder store implementation

Fixes #563

@github-actions github-actions bot added size/L enhancement New feature or request labels Aug 8, 2024
@ushabelgur ushabelgur self-assigned this Aug 8, 2024
@ushabelgur ushabelgur marked this pull request as ready for review August 8, 2024 11:57
@ushabelgur ushabelgur requested a review from a team as a code owner August 8, 2024 11:57
@lukasfrank
Copy link
Member

Since reconcileSnapshot influences the processing time of the image provisioning it would be great to add more context by writing events there.

@ushabelgur
Copy link
Contributor Author

ushabelgur commented Aug 12, 2024

Since reconcileSnapshot influences the processing time of the image provisioning it would be great to add more context by writing events there.

Volume metadata is attached only with image, its not being propagated to snapshots currently. If i generate events for snapshot without this volume metadata information, it will not be useful in propagating event. Will try to check if i can populate this info in snapshot.

@lukasfrank
Copy link
Member

Since reconcileSnapshot influences the processing time of the image provisioning it would be great to add more context by writing events there.

Volume metadata is attached only with image, its not being propagated to snapshots currently. If i generate events for snapshot without this volume metadata information, it will not be useful in propagating event. Will try to check if i can populate this info in snapshot.

Can't we say here, that the snapshot was not present and therefore we gonna create it. I think this is still useful information and we also have the image.

@lukasfrank lukasfrank merged commit f08c333 into main Aug 13, 2024
10 checks passed
@lukasfrank lukasfrank deleted the enh/iri_list_events branch August 13, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ListEvents Runtime Interface to Support Cross-Cluster Events
2 participants