Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed WaitGroup bug #580

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Fixed WaitGroup bug #580

merged 4 commits into from
Aug 14, 2024

Conversation

pradumnapandit
Copy link
Contributor

Fixes #572

@pradumnapandit pradumnapandit self-assigned this Aug 14, 2024
@pradumnapandit pradumnapandit requested a review from a team as a code owner August 14, 2024 08:14
@pradumnapandit pradumnapandit marked this pull request as draft August 14, 2024 08:16
@lukasfrank lukasfrank changed the title Implemented wg usage Fixed WaitGroup bug Aug 14, 2024
@lukasfrank lukasfrank added the bug Something isn't working label Aug 14, 2024
@pradumnapandit pradumnapandit marked this pull request as ready for review August 14, 2024 09:08
@github-actions github-actions bot added size/S and removed size/XS labels Aug 14, 2024
@lukasfrank lukasfrank merged commit dc29b2e into ironcore-dev:main Aug 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasfrank lukasfrank lukasfrank approved these changes

Assignees

@pradumnapandit pradumnapandit

Labels
bug Something isn't working integration-tests size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and Correct WaitGroup Usage in Run Function of volumeprovider/app.go
2 participants
@pradumnapandit @lukasfrank