Support setting node Hostname to match Serverclaim name #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
approved these changes
Sep 4, 2024
defo89
force-pushed
the
machine-hostname
branch
from
7b5b24e to
a071584
Compare
defo89
force-pushed
the
machine-hostname
branch
from
a071584 to
f6cd29b
Compare
hardikdr
reviewed
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
$${METAL_HOSTNAME}in kubeadmconfigtemplate to set nodes hostname. It will be replaced by metalmachine (and ServerClaim) name in ignition.Original CAPBK generated ignition is not modified - we only modify the secret created by metalmachine controller.