Prevent VIP listing when listing NATs for 0.0.0.0, fixes #636

ironcore-dev · Jan 16, 2025 · d9ea4ba · d9ea4ba
1 parent 34fac0e
commit d9ea4ba
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/dp_nat.c b/src/dp_nat.c
@@ -774,6 +774,10 @@ int dp_list_nat_local_entries(uint32_t nat_ip, struct dp_grpc_responder *respond
 	int32_t ret;
 	struct dpgrpc_nat *reply;
 
+	// VIP entries use the same table and have data->nat_ip set to 0 so they would match
+	if (nat_ip == 0)
+		return DP_GRPC_OK;
+
 	if (rte_hash_count(ipv4_snat_tbl) == 0)
 		return DP_GRPC_OK;
 

diff --git a/src/grpc/dp_async_grpc.cpp b/src/grpc/dp_async_grpc.cpp
@@ -655,7 +655,7 @@ void DeleteNeighborNatCall::ParseReply(__rte_unused struct dpgrpc_reply* reply)
 
 const char* ListNeighborNatsCall::FillRequest(struct dpgrpc_request* request)
 {
-	DPGRPC_LOG_INFO("Getting NAT info",
+	DPGRPC_LOG_INFO("Listing neighbor Nats",
 					DP_LOG_IPV4STR(request_.nat_ip().address().c_str()));
 	if (!GrpcConv::GrpcToDpAddress(request_.nat_ip(), &request->list_localnat))
 		return "Invalid nat_ip";