Remove release downloader script #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
|
@PlagueCZ |
PlagueCZ
force-pushed
the
feature/rel_download_public
branch
from
1483f8b to
b62f917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that IronCore is public, there is no need for the release downloader using PAT.
Unfortunately for Dockerfile to work well (cache properly) I had to hardcode
dpservice-cliandprometheus-dpdk-exporterversions. Though the upside is that the resulting Docker image will always have "approved" versions.Since touching the Dockerfile I made a few changes to speed it up (layer reduction and better DPDK download link)
I also changed the pytest script to download the client when needed, using the version set in the Dockerfile. This is more of a convenience for developers than anything else. It should maybe also check if the already present version is not obsolete, but I left that to the developer (as that is the previous behavior anyway).