Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPDX to generated source/header files #453

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

PlagueCZ
Copy link
Contributor

@PlagueCZ PlagueCZ commented Dec 6, 2023

Generated files for command-line options do not include SPDX lines. As they are not generated during a build process but instead are committed to git, I changed the generator to add them.

@github-actions github-actions bot added the size/S label Dec 6, 2023
@PlagueCZ PlagueCZ requested a review from guvenc December 6, 2023 12:23
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 6, 2023
@PlagueCZ PlagueCZ linked an issue Dec 6, 2023 that may be closed by this pull request
1 task
Copy link
Collaborator

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@guvenc
Copy link
Collaborator

guvenc commented Dec 6, 2023

@PlagueCZ
Could you please rebase ?

@PlagueCZ PlagueCZ force-pushed the feature/spdx_generated_code branch from 2109c85 to 46fc50a Compare December 6, 2023 16:01
@guvenc guvenc merged commit 46fc50a into main Dec 6, 2023
6 checks passed
@guvenc guvenc deleted the feature/spdx_generated_code branch December 6, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes connected to IronCore migration
2 participants