Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IPv6 overlay support for non-offloading path #462

Merged
merged 14 commits into from
Dec 22, 2023

Conversation

guvenc
Copy link
Collaborator

@guvenc guvenc commented Dec 20, 2023

Introduced following network functions to support overlay ipv6 in non-offloading path:

  • IPv6 conntrack support.
  • IPv6 HV-HV routing.
  • IPv6 Loadbalancer support.
  • Alias v6 Prefixes and v6 LB Alias Prefixes.
  • NAT64 support.
  • TCP/UDP NAT64.
  • ICMP NAT64.
  • DHCPv6 DNS Support.
  • Scapy tests.
  • v6 Firewall.

Scapy tests can be still extended but for the beginning there is at least one scapy test to test the introduced ipv6 overlay
network function.

Unfortunately the commits are not suitable to be reviewed separately. As there is a cleanup commit at the end of the
series so better take a look to the complete PR diff. The changes are somehow connected anyway.

checkpatch fails because of the cpp changes.

Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
@guvenc guvenc requested a review from a team as a code owner December 20, 2023 11:50
@github-actions github-actions bot added size/XXL documentation Improvements or additions to documentation enhancement New feature or request labels Dec 20, 2023
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
@guvenc guvenc force-pushed the feature/ipv6_conntrack branch 2 times, most recently from 9b4c8f5 to bc183f8 Compare December 20, 2023 12:03
@guvenc guvenc force-pushed the feature/ipv6_conntrack branch 3 times, most recently from e2307b8 to d347663 Compare December 20, 2023 16:42
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
@guvenc guvenc force-pushed the feature/ipv6_conntrack branch from d347663 to 4c54518 Compare December 20, 2023 18:45
@guvenc guvenc requested review from byteocean and PlagueCZ and removed request for a team December 20, 2023 18:59
Copy link
Contributor

@PlagueCZ PlagueCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, did not find anything major. Compiles and runs in pytest for me too.
I will try running on HW later, but I put this out first so the minor things can be resolved in the meantime.

Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Copy link
Contributor

@PlagueCZ PlagueCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few little things I noticed after reading the changes from today.

Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Copy link
Contributor

@PlagueCZ PlagueCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now

@guvenc guvenc merged commit 341c71b into main Dec 22, 2023
@guvenc guvenc deleted the feature/ipv6_conntrack branch December 22, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants