-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce IPv6 overlay support for non-offloading path #462
Conversation
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
9b4c8f5
to
bc183f8
Compare
e2307b8
to
d347663
Compare
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
d347663
to
4c54518
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, did not find anything major. Compiles and runs in pytest for me too.
I will try running on HW later, but I put this out first so the minor things can be resolved in the meantime.
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few little things I noticed after reading the changes from today.
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now
Introduced following network functions to support overlay ipv6 in non-offloading path:
Scapy tests can be still extended but for the beginning there is at least one scapy test to test the introduced ipv6 overlay
network function.
Unfortunately the commits are not suitable to be reviewed separately. As there is a cleanup commit at the end of the
series so better take a look to the complete PR diff. The changes are somehow connected anyway.
checkpatch fails because of the cpp changes.