Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pf1 proxy #634

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Remove pf1 proxy #634

merged 2 commits into from
Jan 16, 2025

Conversation

PlagueCZ
Copy link
Contributor

@PlagueCZ PlagueCZ commented Jan 13, 2025

As the solution for non-working PF1 in multiport-eswitch has been found, the workaround is no longer needed.

All code is removed and documentation is updated with the mention of missing kernel option in Debian.

Pytest suite is working for on-hardware tests using two locally connected machines and when --port-redundancy option is used this automatically tests if PF1 is working properly otherwise scapy would not be able to see packets returned by the reflector on the other machine.

Fixes #635
Fixes #597

@github-actions github-actions bot added size/XL documentation Improvements or additions to documentation enhancement New feature or request labels Jan 13, 2025
@byteocean byteocean marked this pull request as ready for review January 15, 2025 09:16
@byteocean byteocean requested a review from a team as a code owner January 15, 2025 09:16
@byteocean
Copy link
Contributor

byteocean commented Jan 15, 2025

Thanks a lot for working on removing relevant code for the proxy port. These changes LGTM.

It is a pity that we had to work on such complex workaround, but it is nice that we now get natively supported link redundancy. In this journey, I think we got two key experience, thus I would like to highlight here for future usage:

  1. the usage of async templates. the approaches of creating, instantiating match/action templates can be found in Introduce multiport-eswitch mode to support continuous communication #589
  2. VF can be used by the hosts to send/receive packets, not just be used by VMs. the relevant code can be found Use mlx5 vf as PF1 proxy #614

Copy link
Contributor

@byteocean byteocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compilation and tests worked well in my environment.

@guvenc guvenc linked an issue Jan 15, 2025 that may be closed by this pull request
@PlagueCZ PlagueCZ force-pushed the feature/remove_pf1_proxy branch from 10040ea to 34fac0e Compare January 15, 2025 16:16
@PlagueCZ PlagueCZ requested a review from guvenc January 16, 2025 15:25
Copy link
Collaborator

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@guvenc guvenc merged commit 34fac0e into main Jan 16, 2025
8 checks passed
@guvenc guvenc deleted the feature/remove_pf1_proxy branch January 16, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PF1-Proxy implementation Rework pytest mellanox support
3 participants