Add listing of all nat entries to gRPC protocol #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed nat-ip from required flags of list nats and it now defaults to 0.0.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to list all NAT entries by providing address 0.0.0.0 as the filter (the client does that automatically if no filter is given).
During implementation I also noticed a bug that is closely connected, so I included it here. Also there was an obsolete log line for listing the neighboring nats.
Fixes #637
The change required changing the protobuf specification, but I only added a field at the end, which should ensure backwards-compatibility and also enable old client code to use
dpservice-golibrary without any issues.That is why the names in the gRPC structure are looking strange.
This code is running on one node in OSC LAB, with an old metalnet, so backwards compatibility is tested.