Fix controlplane controller

Remove storageclass healthcheck and fix nil pointer deref on infrastructure status

pkg/controller/controlplane/valuesprovider.go

@@ -144,10 +144,6 @@ func (vp *valuesProvider) GetConfigChartValues(
 	cp *extensionsv1alpha1.ControlPlane,
 	cluster *extensionscontroller.Cluster,
 ) (map[string]interface{}, error) {
-	infrastructureStatus := &apismetal.InfrastructureStatus{}
-	if _, _, err := vp.decoder.Decode(cp.Spec.InfrastructureProviderStatus.Raw, nil, infrastructureStatus); err != nil {
-		return nil, fmt.Errorf("failed to decode infrastructure status: %w", err)
-	}
 	// Collect config chart values
 	return map[string]interface{}{
 		metal.ClusterFieldName: cluster.ObjectMeta.Name,

pkg/controller/controlplane/valuesprovider_test.go

@@ -74,9 +74,6 @@ var _ = Describe("Valueprovider Reconcile", func() {
 							}),
 						},
 					},
-					InfrastructureProviderStatus: &runtime.RawExtension{
-						Raw: encode(&apismetal.InfrastructureStatus{}),
-					},
 				},
 			}
 			Expect(k8sClient.Create(ctx, cp)).To(Succeed())
@@ -129,9 +126,6 @@ var _ = Describe("Valueprovider Reconcile", func() {
 							}),
 						},
 					},
-					InfrastructureProviderStatus: &runtime.RawExtension{
-						Raw: encode(&apismetal.InfrastructureStatus{}),
-					},
 				},
 			}
 			providerCloudProfile := &apismetal.CloudProfileConfig{}

pkg/controller/healthcheck/add.go

@@ -60,10 +60,6 @@ func RegisterHealthChecks(ctx context.Context, mgr manager.Manager, opts healthc
 				ConditionType: string(gardencorev1beta1.ShootSystemComponentsHealthy),
 				HealthCheck:   general.CheckManagedResource(genericcontrolplaneactuator.ControlPlaneShootChartResourceName),
 			},
-			{
-				ConditionType: string(gardencorev1beta1.ShootSystemComponentsHealthy),
-				HealthCheck:   general.CheckManagedResource(genericcontrolplaneactuator.StorageClassesChartResourceName),
-			},
 		},
 		sets.New[gardencorev1beta1.ConditionType](gardencorev1beta1.ShootSystemComponentsHealthy),
 	); err != nil {