Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump mcm-provider-metal #20

Closed
wants to merge 1 commit into from
Closed

bump mcm-provider-metal #20

wants to merge 1 commit into from

Conversation

defo89
Copy link
Contributor

@defo89 defo89 commented Aug 7, 2024

Proposed Changes

  • bump mcm to have fixed ignition secret key

@defo89 defo89 requested a review from a team as a code owner August 7, 2024 08:05
@defo89 defo89 requested a review from Nuckal777 August 7, 2024 08:06
@afritzler
Copy link
Member

afritzler commented Aug 7, 2024

There is no need to patch the sha of the deps in the extension itself. You can override the image vector like that in the ControllerDeployment:

apiVersion: core.gardener.cloud/v1beta1
kind: ControllerDeployment
metadata:
  name: provider-metal
type: helm
providerConfig:
  chart: foobar
  values:
    image:
      tag: sha-eef069d
    imageVectorOverwrite: |
      images:
        - name: machine-controller-manager-provider-metal
          sourceRepository: github.com/ironcore-dev/machine-controller-manager-provider-metal
          repository: ghcr.io/ironcore-dev/machine-controller-manager-provider-metal
          tag: foobar

@afritzler
Copy link
Member

I would suggest to only use stable version/tags in the image.yaml.

@defo89
Copy link
Contributor Author

defo89 commented Aug 7, 2024

thanks, we will do it manually for now and revisit when stable is there

@defo89 defo89 closed this Aug 7, 2024
@defo89 defo89 deleted the bump/mcm-provider-metal branch August 7, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants